Page MenuHomePhabricator

[Cashtab] [final countdown bch param p3] Change name of send tx error code object
ClosedPublic

Authored by bytesofman on Dec 8 2022, 04:29.

Details

Summary

T2730

Depends on D12807

Change name of global error code object SEND_BCH_ERRORS to SEND_XEC_ERRORS

Test Plan

Confirm this is only a name change
grep -r SEND_BCH_ERRORS src/ has no result

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

  tokenMethods.js                |     100 |      100 |     100 |     100 |                                                                                                                                                                                                                                                                                                                                                                                    
  txBuilder.js                   |   63.88 |    42.85 |      50 |   65.71 | 11,43-53,69-72,89                                                                                                                                                                                                                                                                                                                                                                  
  validation.js                  |   92.89 |    80.98 |   84.61 |   93.18 | 22-23,79-86,123-130,234,280,330,342                                                                                                                                                                                                                                                                                                                                                
 src/utils/icons                 |    2.52 |        0 |       0 |    2.72 |                                                                                                                                                                                                                                                                                                                                                                                    
  cropImage.js                   |    2.27 |        0 |       0 |    2.43 | 2-78                                                                                                                                                                                                                                                                                                                                                                               
  resizeImage.js                 |    2.77 |        0 |       0 |    3.03 | 2-51                                                                                                                                                                                                                                                                                                                                                                               
  roundImage.js                  |    2.56 |        0 |       0 |    2.77 | 2-57                                                                                                                                                                                                                                                                                                                                                                               
---------------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='1793']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='4297']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='738']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2056']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='307']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='964']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='1763']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='4192']
##teamcity[blockClosed name='Code Coverage Summary']

Summary of all failing tests
FAIL src/hooks/__tests__/migrations.test.js
  ● Test suite failed to run

    Cannot find module '@psf/bch-js' from 'src/hooks/__tests__/migrations.test.js'

      1 | import { currency } from '../../components/Common/Ticker';
      2 | import BigNumber from 'bignumber.js';
    > 3 | import BCHJS from '@psf/bch-js';
        | ^
      4 | import { fromSatoshisToXec, fromXecToSatoshis } from 'utils/cashMethods';
      5 |
      6 | describe('Testing functions for upgrading Cashtab', () => {

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (src/hooks/__tests__/migrations.test.js:3:1)

FAIL src/utils/__tests__/cashMethods.test.js
  ● Test suite failed to run

    Cannot find module '@psf/bch-js' from 'src/utils/__tests__/cashMethods.test.js'

      84 |
      85 | import mockLegacyWallets from 'hooks/__mocks__/mockLegacyWallets';
    > 86 | import BCHJS from '@psf/bch-js';
         | ^
      87 | import sendBCHMock from '../../hooks/__mocks__/sendBCH';
      88 | import {
      89 |     activeWebsocketAlpha,

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (src/utils/__tests__/cashMethods.test.js:86:1)


Test Suites: 2 failed, 19 passed, 21 total
Tests:       267 passed, 267 total
Snapshots:   37 passed, 37 total
Time:        12.872 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
This revision is now accepted and ready to land.Dec 8 2022, 06:38