Differential D12832

[Cashtab] [final countdown bch param p4 thru p7]
ClosedPublic
Actions

Authored by bytesofman on Dec 9 2022, 17:41.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC16fc8ef2f07c: [Cashtab] [final countdown bch param p4 thru p7]

Summary

T2730

Combining parts 4 through 7 of this diff that is already up, due to arcanist errors in squashing that stacked diff.

Test Plan

See test plans of parts 4 through 7, already up.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 9 2022, 17:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 9 2022, 17:41

bytesofman requested review of this revision.Dec 9 2022, 17:41

Harbormaster completed remote builds in B21491: Diff 37162.Dec 9 2022, 17:45

kieran709 added a subscriber: kieran709.Dec 9 2022, 18:01

kieran709 added inline comments.

web/cashtab/src/components/Send/SendToken.js
187 ↗	(On Diff #37162)	Flagging that in the previously accepted pts 4 through 7 this line isn't marked as changed.

When sending an encrypted msg, the wallet that sent the encrypted msg repeatedly fires this warning. Tested on a wallet with no recent outgoing encrypted msgs and didn't get the error. I assume this isn't a big deal but wanted to flag it in case it is unexpected behavior.

invalidhashsize2.png (711×1 px, 286 KB)

Update: this error does not appear to be related to this diff

In D12832#285559, @kieran709 wrote:

When sending an encrypted msg, the wallet that sent the encrypted msg repeatedly fires this warning. Tested on a wallet with no recent outgoing encrypted msgs and didn't get the error. I assume this isn't a big deal but wanted to flag it in case it is unexpected behavior.

Do you see the same msg at cashtab.com for this wallet?

web/cashtab/src/components/Send/SendToken.js
187 ↗	(On Diff #37162)	Good catch. I made this change to part 2 this morning and did not propagate the rebase into parts 4 through 7 that were pushed to phab. Will add it in here.

Adding error handling fix from this morning to part 2

Harbormaster completed remote builds in B21492: Diff 37163.Dec 9 2022, 19:09

kieran709 accepted this revision.Dec 9 2022, 20:16

This revision is now accepted and ready to land.Dec 9 2022, 20:16

Closed by commit rABC16fc8ef2f07c: [Cashtab] [final countdown bch param p4 thru p7] (authored by bytesofman). · Explain WhyDec 9 2022, 20:50

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC16fc8ef2f07c: [Cashtab] [final countdown bch param p4 thru p7].

bytesofman mentioned this in D12822: [Cashtab] [final countdown bch param p4] Convert useBCH.js from hook to util.Dec 9 2022, 20:50

bytesofman mentioned this in D12823: [Cashtab] [final countdown bch param p5] Remove BCHJS from unit tests.

bytesofman mentioned this in D12824: [Cashtab] [final countdown bch param p6] Remove lingering jestBCH artifacts.

bytesofman mentioned this in D12825: [Cashtab] [final countdown bch param p7/7] Patch lint errors in transactions.test.js.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

package-lock.json

892 lines

1 line

src/

components/

Airdrop/

3 lines

Home/

6 lines

Send/

4 lines

4 lines

Tokens/

3 lines

__tests__/

CreateTokenForm.test.js

3 lines

hooks/

__mocks__/

__tests__/

migrations.test.js

30 lines

	utils/
	hooks/

__mocks__/

__tests__/

	transactions.test.js
	useBCH.test.js

27 lines

utils/

__tests__/

cashMethods.test.js

50 lines

txBuilder.test.js

2 lines

transactions.js

485 lines

Diff 37169

web/cashtab/package-lock.json

Loading...

web/cashtab/package.json

Loading...

web/cashtab/src/components/Airdrop/Airdrop.js

Loading...

web/cashtab/src/components/Home/Home.js

Loading...

web/cashtab/src/components/Send/Send.js

Loading...

web/cashtab/src/components/Send/SendToken.js

Loading...

web/cashtab/src/components/Tokens/Tokens.js

Loading...

web/cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

Loading...

web/cashtab/src/hooks/mocks/burnToken.js

Loading...

web/cashtab/src/hooks/mocks/createToken.js

Loading...

web/cashtab/src/hooks/mocks/sendBCH.js

Loading...

web/cashtab/src/hooks/tests/migrations.test.js

Loading...

web/cashtab/src/hooks/tests/useBCH.test.js

Loading...

web/cashtab/src/hooks/useBCH.js

Loading...

web/cashtab/src/utils/mocks/burnToken.js

Loading...

web/cashtab/src/utils/mocks/createToken.js

Loading...

web/cashtab/src/utils/mocks/sendBCH.js

Loading...

web/cashtab/src/utils/tests/cashMethods.test.js

Loading...

web/cashtab/src/utils/tests/transactions.test.js

Loading...

web/cashtab/src/utils/tests/txBuilder.test.js

Loading...

web/cashtab/src/utils/transactions.js

Loading...