Page MenuHomePhabricator

[Cashtab] [wallet mgmt improvements p2] Only update wallet when user has changed wallets
ClosedPublic

Authored by bytesofman on Dec 10 2022, 18:08.

Details

Summary

T2822

Depends on D12841

The settings page needs to update the savedWallets data in state whenever the user has changed wallets. Since all wallets have unique names, wallet.name is the right param to monitor for changes. If you just use wallet, this loop also runs every time the update function in useWallet.js runs.

Test Plan

npm start
Monitor the dev log for a couple of minutes to ensure that update has run several times
Note the msg User has changed the active wallet in Configure.js only appears when you change active wallets

Diff Detail

Repository
rABC Bitcoin ABC
Branch
stack-to-improve-wallet-mgmt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21510
Build 42668: Build Diffcashtab-tests
Build 42667: arc lint + arc unit