[eCash dev libraries] [p5 ecash-ops] Clone minimaldata from bitcoinjs
ClosedPublic
Actions

Authored by bytesofman on Dec 12 2022, 00:26.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC432c7bce9187: [eCash dev libraries] [p5 ecash-ops] Clone minimaldata from bitcoinjs

Summary

T2847

Depends on D12858

This diff clones in the latest version of minimaldata from bitcoinjs. This version is a few commits behind the PSF version. You can see the differences here: https://github.com/christroutner/minimaldata/commits/master

Because these changes involve bringing in bitcoincash-ops, which we have now replaced with ecash-ops, we will do them in this stack.

Test Plan

Confirm this diff is pulling in this repo: https://github.com/bitcoinjs/minimaldata

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-ecash-ops

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	web/minimaldata/.travis.yml:14	indentation	yamllint found an issue:
Warning	web/minimaldata/.travis.yml:15	indentation	yamllint found an issue:

Unit

No Test Coverage

Build Status

Buildable 21529
Build 42704: Build Diff
Build 42703: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 12 2022, 00:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2022, 00:26

bytesofman requested review of this revision.Dec 12 2022, 00:26

Harbormaster completed remote builds in B21529: Diff 37216.Dec 12 2022, 00:26

bytesofman added a child revision: D12860: [eCash dev libraries] [p6 ecash-ops] Change folder name from minimaldata to ecash-minimaldata.Dec 12 2022, 00:29

Looks fine, just update with the linting corrections to .travis.yml

In D12859#286155, @emack wrote:

Looks fine, just update with the linting corrections to .travis.yml

Since these are only warnings, and they do not recur in part 6, I think it's okay to ignore this.

Will see if there are issues with landing the stack. But the stack that lands will only be the final version, and will not have web/minimaldata anywhere.

emack accepted this revision.Dec 12 2022, 22:04

This revision is now accepted and ready to land.Dec 12 2022, 22:04

This revision was landed with ongoing or failed builds.Dec 14 2022, 16:19

Closed by commit rABC432c7bce9187: [eCash dev libraries] [p5 ecash-ops] Clone minimaldata from bitcoinjs (authored by bytesofman). · Explain Why

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC432c7bce9187: [eCash dev libraries] [p5 ecash-ops] Clone minimaldata from bitcoinjs.