Page MenuHomePhabricator
Differential D1285

Ensure the http server accept request at least twice as large as the block size.
ClosedPublic
Actions

Authored by deadalnix on Apr 12 2018, 20:32.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGING84360431b66f: Ensure the http server accept request at least twice as large as the block size.
rABC84360431b66f: Ensure the http server accept request at least twice as large as the block size.
Summary

As per title. This ensures it is always possible to submit blocks via RPC.

Fixes T319

Test Plan

Added a test case to abc-p2p-fullblocktest where a very large block is submited via RPC.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
largerpcsubmit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2307
Build 2752: Bitcoin ABC Buildbot (legacy)
Build 2751: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 12 2018, 20:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2018, 20:32
teamcity added a subscriber: teamcity.Apr 12 2018, 20:40

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel requested changes to this revision.Apr 12 2018, 20:56
schancel added a subscriber: schancel.
schancel added inline comments.
src/httpserver.cpp
43 ↗(On Diff #3489)

under wish -> under which

This makes no sense to me.

How about:

/** Maximum HTTP post body size.  Twice the maximum block size is added to this value in practice. */
static const size_t BASE_MAXIMUM_HTTP_BODY_SIZE = 0x02000000;
44 ↗(On Diff #3489)

Why is this and MAX_SIZE using hex? Are these values related?

static const uint64_t MAX_SIZE = 0x02000000
424 ↗(On Diff #3489)

I thought you wanted a solution that was specific to submitblock?

This revision now requires changes to proceed.Apr 12 2018, 20:56
Harbormaster completed remote builds in B2304: Diff 3489.Apr 12 2018, 20:57
teamcity added a comment.Apr 12 2018, 20:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added inline comments.Apr 12 2018, 22:58
src/httpserver.cpp
44 ↗(On Diff #3489)

No they aren't related.

424 ↗(On Diff #3489)

Well, there are no way to do that considering the way things are setup right now.

deadalnix updated this revision to Diff 3492.Apr 12 2018, 22:58

Fix typo

teamcity added a comment.Apr 12 2018, 23:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix edited the summary of this revision. (Show Details)Apr 12 2018, 23:01
deadalnix added a task: Restricted Maniphest Task.
schancel accepted this revision.Apr 12 2018, 23:06
schancel added inline comments.
src/httpserver.cpp
43

This still makes no sense, but √

This revision is now accepted and ready to land.Apr 12 2018, 23:06
deadalnix updated this revision to Diff 3493.Apr 12 2018, 23:10

reformulate comment as per suggestion

Closed by commit rABC84360431b66f: Ensure the http server accept request at least twice as large as the block size. (authored by deadalnix). · Explain WhyApr 12 2018, 23:10
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 12 2018, 23:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 12 2018, 23:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2307: Diff 3492.Apr 12 2018, 23:21
teamcity added a comment.Apr 12 2018, 23:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2308: Diff 3493.Apr 12 2018, 23:38

Revision Contents
Changeset List

PathSize
src/
10 lines
test/
functional/
5 lines

Diff 3492

View Options

src/httpserver.cpp

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...