Page MenuHomePhabricator

[eCash dev libraries] [p8 ecash-ops] Add pushdata-bitcoin
ClosedPublic

Authored by bytesofman on Dec 12 2022, 14:34.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC2ba15a6d5585: [eCash dev libraries] [p8 ecash-ops] Add pushdata-bitcoin
Summary

T2847

Depends on D12861

Bring pushdata-bitcoin into the monorepo. We need this to make sure all dependencies are on the same page.

Bitcoin state:

minimaldata requires bitcoin-ops and pushdata-bitcoin as a dependency
pushdata-bitcoin requires bitcoin-ops as a dependency

BCH state:

minimaldata requires bitcoincash-ops and pushdata-bitcoin as a dependencies
pushdata-bitcoin still using bitcoin-ops as a dependency

eCash desired end state:
We want all of these libraries to depend only on eCash versions. Hence,

ecash-minimaldata will require ecash-ops and pushdata-ecash
pushdata-ecash will require ecash-ops

These libraries have been static for a long time and this is expected to continue. However, we cannot expect new developers on eCash to understand the evolution of crypto forks and development for the last decade. So, it's important we keep eCash specific versions of these packages (especially if they depend on each other) in one place. The ABC monorepo is the best option.

Test Plan

Confirm this diff was created by

cd web
git clone https://github.com/bitcoinjs/pushdata-bitcoin.git
cd pushdata-bitcoin
rm -rf .git

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-ecash-ops
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21536
Build 42717: Build Diff
Build 42716: arc lint + arc unit