Page MenuHomePhabricator
Differential D12869

[eCash dev libraries] [p12 ecash-ops] Typo fix in ecash-minimaldata
ClosedPublic
Actions

Authored by bytesofman on Dec 12 2022, 14:54.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCf8b5986d3897: [eCash dev libraries] [p12 ecash-ops] Typo fix in ecash-minimaldata
Summary

T2847

Depends on D12868

Patch confusing typo in README for ecash-minimaldata

Test Plan

Confirm that package name matches directory name matches README references

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-ecash-ops
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21541
Build 42727: Build Diff
Build 42726: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 12 2022, 14:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2022, 14:54
bytesofman requested review of this revision.Dec 12 2022, 14:54
Harbormaster completed remote builds in B21541: Diff 37232.Dec 12 2022, 14:54
bytesofman added a child revision: D12870: [eCash dev libraries] [p13 ecash-ops] ecash dependencies all the way down.Dec 12 2022, 15:00
emack requested changes to this revision.Dec 13 2022, 11:35
emack added a subscriber: emack.
emack added inline comments.
web/ecash-minimaldata/README.md
3

npm package link needs updating

This revision now requires changes to proceed.Dec 13 2022, 11:35
bytesofman requested review of this revision.Dec 13 2022, 14:17
bytesofman added inline comments.
web/ecash-minimaldata/README.md
3

Handled here, D12881

No point in fixing it here because need to publish a new version to fix the npm page

emack accepted this revision.Dec 13 2022, 14:18

Resolved via D12881

This revision is now accepted and ready to land.Dec 13 2022, 14:18
Closed by commit rABCf8b5986d3897: [eCash dev libraries] [p12 ecash-ops] Typo fix in ecash-minimaldata (authored by bytesofman). · Explain WhyDec 14 2022, 16:19
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf8b5986d3897: [eCash dev libraries] [p12 ecash-ops] Typo fix in ecash-minimaldata.

Revision Contents
Changeset List

PathSize
web/
ecash-minimaldata/
6 lines
4 lines
2 lines

Diff 37232

View Options

web/ecash-minimaldata/CHANGELOG.md

Loading...
View Options

web/ecash-minimaldata/README.md

Loading...
View Options

web/ecash-minimaldata/package.json

Loading...