As requested, adding the explorer.e.cash repo to the mono repo
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCfa8e107f61e6: Adding the explorer to the monorepo
Open the explorer folder in the web directory. Try running the app (see the readme for instructions)
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- add-explorer
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21602 Build 42845: Build Diff Build 42844: arc lint + arc unit
Event Timeline
| web/explorer/explorer-server/code/webix/webix.js | ||
|---|---|---|
| 5 ↗ | (On Diff #37298) | That is incompatible with our MIT license |
Comment Actions
Looks like the "webix" and "semantic-ui" files probably don't belong in our repository.
Seems like they are libraries, can they be linked externally?
Also, the Webix license is GPL so not compatible with our codebase (MIT). It will probably need to be switched out for something else.
| web/explorer/explorer-server/src/templating/filters.rs | ||
|---|---|---|
| 195 ↗ | (On Diff #37316) | |
| web/explorer/README.md | ||
|---|---|---|
| 11 ↗ | (On Diff #37316) | 4 levels !? |
| 15 ↗ | (On Diff #37316) | Looks like you want to supply an environment variable or similar that points to the bitcoinsuite directory |
| 64 ↗ | (On Diff #37316) | Which libraries ? |
| 70 ↗ | (On Diff #37316) | IMO this doesn't belong in a README. There are a ton of ways to run the explorer systemd is only one such example. Also in the service unit is better provided in a sample file rather than in a markdown code block. |
| 112 ↗ | (On Diff #37316) | That's kinda expected isn't it ? |
| web/explorer/explorer-exe/Cargo.toml | ||
| 8 ↗ | (On Diff #37316) | see above comment |
| web/explorer/explorer-server/Cargo.toml | ||
| 10 ↗ | (On Diff #37316) | dito |
| web/explorer/explorer-server/assets/known_bugs.md | ||
| 1 ↗ | (On Diff #37316) | I don't think this file makes sense, the bugs should be in a bug tracker (and there are much more known bugs than this one, see github issues) |
| web/explorer/explorer-server/assets/ludwig.png | ||
| 1 ↗ | (On Diff #37316) | What is this used for ? |
| web/explorer/explorer-server/code/address.js | ||
| 68 ↗ | (On Diff #37316) | Don't put commented code in the repo |
| web/explorer/README.md | ||
|---|---|---|
| 11 ↗ | (On Diff #37326) | This still needs to be fixed |
| web/explorer/explorer-server/assets/network-background2.png | ||
| 1 ↗ | (On Diff #37326) | Why is there 2 background files ? |
| web/explorer/explorer-server/code/blocks.js | ||
| 158 ↗ | (On Diff #37326) | ? |
| web/explorer/explorer-server/code/common.js | ||
| 39 ↗ | (On Diff #37326) | Remove |
| 58 ↗ | (On Diff #37326) | That's not in par with the style for other if statements. Maybe it deserves a prettier config adjustment ? |
| 145 ↗ | (On Diff #37326) | Please go over the whole code and clean all the parts that are commented out. |
| web/explorer/explorer-server/code/moment.min.js | ||
| 1 ↗ | (On Diff #37326) | This is an external library and afaict it's missing the associated license file/copyright |
| web/explorer/explorer-server/code/styles/index.css | ||
| 192–193 ↗ | (On Diff #37326) | Remove |
| 852 ↗ | (On Diff #37326) | dito, and in various other places |
| web/explorer/README.md | ||
|---|---|---|
| 15 ↗ | (On Diff #37316) | The path is hardcoded to be 4 levels above. if you can supply some environment variable with the path to the bitcoinsuite/ directory, (e.g. called BITCOINSUITE_DIR), you can do something like: bitcoinsuite-chronik-client = { path = "$BITCOINSUITE_DIR/bitcoinsuite-chronik-client" }(of course the syntax is wrong) in the Cargo.toml and you remove the nesting requirements for the parent directories, only the children needs to match the expectations which is fine. |
Comment Actions
Okay for sure makes sense. If you find any references for the proper syntax to do something like that let me know...I'm not sure how to write it
Im guessing would be ideal to define that variable in the config.toml right?
Comment Actions
Im not sure its doable @Fabien. I asked Tobias but he didnt have a solution, and I cant find anything about using environmental variable like that...Tobias did say they are trying to make the bitcoinsuite a cargo crate which will be even cleaner...
Comment Actions
The README remains to be updated, but otherwise it's good to go
| web/explorer/README.md | ||
|---|---|---|
| 18 ↗ | (On Diff #37401) | That paragraph is no longer true |