Add extra info to script parsing error to make debugging easier
ClosedPublic
Actions

Authored by jasonbcox on Apr 14 2018, 23:06.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING8716d6334f44: Add extra info to script parsing error to make debugging easier
rABC8716d6334f44: Add extra info to script parsing error to make debugging easier

Summary

Parsing errors in /src/test/data/*.json files give unknown location(0): fatal error in "script_json_test": std::runtime_error: script parse error which is totally useless for debugging. Related to T312.

Test Plan

make check + make check with a line that doesn't parse (error message now prints the line's contents, making debugging easier)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 14 2018, 23:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2018, 23:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2320: Diff 3511.Apr 14 2018, 23:28

deadalnix accepted this revision.Apr 15 2018, 20:49

This revision is now accepted and ready to land.Apr 15 2018, 20:49

Closed by commit rABC8716d6334f44: Add extra info to script parsing error to make debugging easier (authored by jasonbcox). · Explain WhyApr 16 2018, 17:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

core_read.cpp

2 lines

Diff 3516

View Options

Add extra info to script parsing error to make debugging easierClosedPublicActions