Differential D12917

Use no test fixture for the RCU unit tests
ClosedPublic
Actions

Authored by Fabien on Dec 19 2022, 17:54.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC543e0468399a: Use no test fixture for the RCU unit tests

Summary

So far the test fixture makes no use of any RCU pointer, but the test will break otherwise as it as expectations on the cleanup count.
Since the fixture is unused, the most simple solution is to drop it.

Test Plan

ninja check-bitcoin-rcu_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 19 2022, 17:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2022, 17:54

Fabien requested review of this revision.Dec 19 2022, 17:54

Harbormaster completed remote builds in B21630: Diff 37369.Dec 19 2022, 18:07

PiRK accepted this revision.Dec 20 2022, 08:49

This revision is now accepted and ready to land.Dec 20 2022, 08:49

Closed by commit rABC543e0468399a: Use no test fixture for the RCU unit tests (authored by Fabien). · Explain WhyDec 20 2022, 14:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC543e0468399a: Use no test fixture for the RCU unit tests.

Revision Contents
Changeset List

Path

Size

src/

test/

rcu_tests.cpp

2 lines

Diff 37388

View Options

Use no test fixture for the RCU unit testsClosedPublicActions