Page MenuHomePhabricator

[Cashtab] Improve vertical centering of QRCode in Receive.js
ClosedPublic

Authored by kieran709 on Dec 19 2022, 21:27.

Details

Summary

Related to T2814. QRCode has been given a margin-top of 15%. If you think it would look better, I would stack this diff with one which moves the new InfoCtn above the QRCode so that all content is visible above the fold.

Test Plan

cd web/cashtab && npm start
navigate to Receive screen
observe that the QRCode component is pushed further towards the center of the screen

Diff Detail

Repository
rABC Bitcoin ABC
Branch
improve-vertical-centering-receive
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21639
Build 42918: Build Diffcashtab-tests
Build 42917: arc lint + arc unit

Event Timeline

No need to stack. The info thing on the QR code screen is temporary and will be removed soon.

This revision is now accepted and ready to land.Dec 19 2022, 23:50