Differential D12923

[cashtab] Avoid loss of precision eslint error
ClosedPublic
Actions

Authored by Fabien on Dec 20 2022, 10:50.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC613ca29ddaa4: [cashtab] Avoid loss of precision eslint error

Summary

There are 3 occurrences of eslint no-loss-of-precision in the validation tests, one of them is deliberate and the others can be fixed.

Test Plan

eslint src/utils/

Check there is no error

npm test

Check the validation tests pass

Diff Detail

Repository

rABC Bitcoin ABC

Branch

eslint_loss_precision

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21641
Build 42922: Build Diff	cashtab-tests
Build 42921: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 20 2022, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2022, 10:50

Fabien requested review of this revision.Dec 20 2022, 10:50

Harbormaster completed remote builds in B21641: Diff 37383.Dec 20 2022, 10:52

Fabien added a child revision: D12926: [linter] Use eslint to lint the javascript files.Dec 20 2022, 10:55

bytesofman accepted this revision.Dec 20 2022, 17:40

This revision is now accepted and ready to land.Dec 20 2022, 17:40

Closed by commit rABC613ca29ddaa4: [cashtab] Avoid loss of precision eslint error (authored by Fabien). · Explain WhyDec 21 2022, 08:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC613ca29ddaa4: [cashtab] Avoid loss of precision eslint error.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__tests__/

validation.test.js

5 lines

Diff 37383

View Options

web/cashtab/src/utils/tests/validation.test.js

[cashtab] Avoid loss of precision eslint errorClosedPublicActions