Differential D12924

[cashtab] Ignore eslint false positive for jest import
ClosedPublic
Actions

Authored by Fabien on Dec 20 2022, 10:50.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf45a493d62f9: [cashtab] Ignore eslint false positive for jest import

Summary

From eslint:

Jest is automatically in scope. Do not import "jest", as Jest doesn't export anything.

However this only stands for test files, jest is not automatically in the scope of other files and this causes a false positive, which can be safely ignored with an eslint single line error ignre comment.

Test Plan

cd web/cashtab
npm ci
npm test
eslint scripts/test.js

Diff Detail

Repository

rABC Bitcoin ABC

Branch

eslint_unused_imports

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21642
Build 42924: Build Diff	cashtab-tests
Build 42923: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 20 2022, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2022, 10:50

Fabien requested review of this revision.Dec 20 2022, 10:50

Harbormaster completed remote builds in B21642: Diff 37384.Dec 20 2022, 10:53

Fabien added a child revision: D12926: [linter] Use eslint to lint the javascript files.Dec 20 2022, 10:55

bytesofman accepted this revision.Dec 20 2022, 17:41

This revision is now accepted and ready to land.Dec 20 2022, 17:41

Closed by commit rABCf45a493d62f9: [cashtab] Ignore eslint false positive for jest import (authored by Fabien). · Explain WhyDec 21 2022, 08:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf45a493d62f9: [cashtab] Ignore eslint false positive for jest import.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

scripts/

test.js

1 line

Diff 37384

View Options

web/cashtab/scripts/test.js

[cashtab] Ignore eslint false positive for jest importClosedPublicActions