[build-xec-apps][p2] Added chronik logic
AbandonedPublic
Actions

Authored by bytesofman on Dec 20 2022, 19:41.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Depends on D12931, related to T2264. Logic and object pertaining to the chronik methods. Inclds: 1. object that contains method descriptions, code blocks, names, references to helper functions with space for an icon to be added later, 2. chronik methods and 3. chronik helper functions.

Test Plan

cd web/build-xec-apps/src/utilities
check logic and formatting of chronikHandlers and chronikHelpers, provide any critique regarding the implementation of these functions

cd web/build-xec-apps/assets
navigate to chronikMethods
check formatting of chronikMethods obj, provide any critique regarding the layout of this obj

Diff Detail

Repository

rABC Bitcoin ABC

Branch

build-xec-apps

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21651
Build 42942: Build Diff
Build 42941: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 20 2022, 19:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2022, 19:41

kieran709 requested review of this revision.Dec 20 2022, 19:41

Harbormaster completed remote builds in B21651: Diff 37397.Dec 20 2022, 19:41

kieran709 edited the summary of this revision. (Show Details)Dec 20 2022, 19:42

kieran709 added a parent revision: D12931: [build-xec-apps][p1] Initial Commit.

kieran709 added a child revision: D12933: [build-xec-apps][p3] Added chronik demo components.Dec 20 2022, 20:42

The end result here is okay after checking out part 3. However, it's important to consider how this stuff will look to a reviewer. It's not just a matter of splitting it into parts -- it should build up in a logical way so that testing is straightforward.

In this case, it's not possible to test this code at all -- the test plan involves manually reading several functions.

A better way to present this stack would be