Differential D12954

refactor: remove duplicate code from BlockAssembler
ClosedPublic
Actions

Authored by Fabien on Jan 5 2023, 19:48.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCce0b1b9a2436: refactor: remove duplicate code from BlockAssembler

Summary

There is no change in behavior.
Backport of core#24364.

Depends on D12953.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 5 2023, 19:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2023, 19:48

Fabien requested review of this revision.Jan 5 2023, 19:48

teamcity edited the summary of this revision. (Show Details)Jan 5 2023, 19:48

Harbormaster completed remote builds in B21703: Diff 37467.Jan 5 2023, 20:02

Fabien added a child revision: D12955: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs.Jan 5 2023, 20:31

sdulfari accepted this revision.Jan 5 2023, 22:04

This revision is now accepted and ready to land.Jan 5 2023, 22:04

Closed by commit rABCce0b1b9a2436: refactor: remove duplicate code from BlockAssembler (authored by James O'Beirne <james.obeirne@pm.me>, committed by Fabien). · Explain WhyJan 6 2023, 18:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCce0b1b9a2436: refactor: remove duplicate code from BlockAssembler.

Revision Contents
Changeset List

Path

Size

src/

node/

miner.cpp

8 lines

Diff 37487

View Options

refactor: remove duplicate code from BlockAssemblerClosedPublicActions