Differential D12964

Use explicit types for the Amount
ClosedPublic
Actions

Authored by Fabien on Jan 7 2023, 08:27.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC73f49d55f59a: Use explicit types for the Amount

Summary

Doing otherwise causes the build to fail on MacOS.

Test Plan

Run the OSX CI build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_osx_cast

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21720
Build 43079: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-diff · build-clang-tidy · build-clang
Build 43078: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 7 2023, 08:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2023, 08:27

Fabien requested review of this revision.Jan 7 2023, 08:27

@bot build-osx

teamcity awarded a token.Jan 7 2023, 08:27

Harbormaster completed remote builds in B21720: Diff 37494.Jan 7 2023, 08:42

PiRK accepted this revision.Jan 9 2023, 07:21

This revision is now accepted and ready to land.Jan 9 2023, 07:21

Closed by commit rABC73f49d55f59a: Use explicit types for the Amount (authored by Fabien). · Explain WhyJan 9 2023, 07:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC73f49d55f59a: Use explicit types for the Amount.

Revision Contents
Changeset List

Path

Size

src/

test/

miner_tests.cpp

15 lines

Diff 37494

View Options

Use explicit types for the AmountClosedPublicActions