Page MenuHomePhabricator
Differential D12969

[avalanche] Vote on transactions
ClosedPublic
Actions

Authored by Fabien on Jan 10 2023, 16:44.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC54dc562502ca: [avalanche] Vote on transactions
Summary

Currently guarded behind a hidden flag as the feature is far from complete.
Only voting is implemented, no polling occurs.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 10 2023, 16:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2023, 16:44
Fabien requested review of this revision.Jan 10 2023, 16:44
Fabien updated this revision to Diff 37506.Jan 10 2023, 16:46

Typo and extra newline

sdulfari requested changes to this revision.Jan 10 2023, 17:02
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_avalanche_transaction_voting.py
92 ↗(On Diff #37506)

Needs to test the cases where the txs have been mined into blocks of varying depth.

This revision now requires changes to proceed.Jan 10 2023, 17:02
Harbormaster completed remote builds in B21725: Diff 37505.Jan 10 2023, 17:06
Harbormaster completed remote builds in B21726: Diff 37506.Jan 10 2023, 17:16
Fabien updated this revision to Diff 37507.Jan 10 2023, 17:25

Add a test case for recently mined transactions

Harbormaster completed remote builds in B21727: Diff 37507.Jan 10 2023, 17:41
sdulfari accepted this revision.Jan 10 2023, 17:42
This revision is now accepted and ready to land.Jan 10 2023, 17:42
Closed by commit rABC54dc562502ca: [avalanche] Vote on transactions (authored by Fabien). · Explain WhyJan 10 2023, 20:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC54dc562502ca: [avalanche] Vote on transactions.

Revision Contents
Changeset List

PathSize
src/
2 lines
47 lines
test/
functional/
111 lines
test_framework/
7 lines
lint/
1 line

Diff 37508

View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/lint/check-doc.py

Loading...