Differential D12985

Make blockReward const when checking miner fund
ClosedPublic
Actions

Authored by sdulfari on Jan 17 2023, 18:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2f179cc23642: Make blockReward const when checking miner fund

Summary

It should not be mutable.

Test Plan

ninja && ./test/functional/test_runner.py abc_feature_minerfund

Diff Detail

Repository

rABC Bitcoin ABC

Branch

const-block-reward

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21761
Build 43157: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang
Build 43156: arc lint + arc unit

Event Timeline

sdulfari created this revision.Jan 17 2023, 18:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2023, 18:08

sdulfari requested review of this revision.Jan 17 2023, 18:08

Harbormaster completed remote builds in B21761: Diff 37554.Jan 17 2023, 18:23

Fabien accepted this revision.Jan 17 2023, 19:26

This revision is now accepted and ready to land.Jan 17 2023, 19:26

Closed by commit rABC2f179cc23642: Make blockReward const when checking miner fund (authored by sdulfari). · Explain WhyJan 17 2023, 19:33

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC2f179cc23642: Make blockReward const when checking miner fund.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

2 lines

Diff 37554

View Options

Make blockReward const when checking miner fundClosedPublicActions