Page MenuHomePhabricator
Differential D12993

refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace
ClosedPublic
Actions

Authored by PiRK on Jan 18 2023, 11:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCabe358c04beb: refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace
Summary

Credit to ajtowns for this suggestion, thanks!

This is a partial backport of core#24050
https://github.com/bitcoin/bitcoin/pull/24050/commits/dd79dad17545424d145e846026518d70da594380
https://github.com/bitcoin/bitcoin/pull/24050/commits/6c23c415613d8b847e6f6a2f872be893da9f4384

Depends on D12992

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 18 2023, 11:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 11:21
PiRK requested review of this revision.Jan 18 2023, 11:21
teamcity edited the summary of this revision. (Show Details)Jan 18 2023, 11:21
Harbormaster completed remote builds in B21770: Diff 37567.Jan 18 2023, 11:42
PiRK added a child revision: D12994: style: Modernize range-based loops over m_block_index.Jan 18 2023, 13:59
Fabien accepted this revision.Jan 19 2023, 09:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/blockstorage.cpp
50 ↗(On Diff #37567)

can be const

224 ↗(On Diff #37567)

dito

226 ↗(On Diff #37567)

it's not really necessary, but OK

This revision is now accepted and ready to land.Jan 19 2023, 09:05
PiRK mentioned this in D12991: blockstorage: Make m_block_index own CBlockIndex's.Jan 20 2023, 09:02
PiRK updated this revision to Diff 37611.Jan 20 2023, 09:48

review

Harbormaster completed remote builds in B21803: Diff 37611.Jan 20 2023, 10:01
Closed by commit rABCabe358c04beb: refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 20 2023, 15:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCabe358c04beb: refactor: Rewrite InsertBlockIndex and AddToBlockIndex with try_emplace.
PiRK mentioned this in D13021: style-only: No need for std::pair for vSortedByHeight.Jan 23 2023, 10:13
PiRK mentioned this in rABCcecbcba200c8: style-only: No need for std::pair for vSortedByHeight.Jan 23 2023, 15:48

Revision Contents
Changeset List

PathSize
src/
node/
35 lines

Diff 37621

View Options

src/node/blockstorage.cpp

Loading...