Differential D12995

[avalanche] Make the finalization tip pointer const
ClosedPublic
Actions

Authored by Fabien on Jan 18 2023, 15:01.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC912037f6b306: [avalanche] Make the finalization tip pointer const

Summary

The block index is not supposed to be modified from that pointer, so make it const.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_finalization_tip_const

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21778
Build 43191: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43190: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 18 2023, 15:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 15:01

Fabien requested review of this revision.Jan 18 2023, 15:01

Harbormaster completed remote builds in B21778: Diff 37578.Jan 18 2023, 15:22

Fabien added a child revision: D12998: [avalanche] Leverage AnyVoteItem to have a single VoteItemUpdate object.Jan 18 2023, 15:43

sdulfari accepted this revision.Jan 18 2023, 17:31

This revision is now accepted and ready to land.Jan 18 2023, 17:31

Closed by commit rABC912037f6b306: [avalanche] Make the finalization tip pointer const (authored by Fabien). · Explain WhyJan 19 2023, 08:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC912037f6b306: [avalanche] Make the finalization tip pointer const.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

2 lines

Diff 37578

View Options

[avalanche] Make the finalization tip pointer constClosedPublicActions