Page MenuHomePhabricator
Differential D1300

Make script_tests.cpp output verbose errors.
ClosedPublic
Actions

Authored by schancel on Apr 20 2018, 21:17.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING90ce4fff78f1: Make script_tests.cpp output verbose errors.
rABC90ce4fff78f1: Make script_tests.cpp output verbose errors.
Summary

Currently, when a test from script_test.json has an invalid format
the test runner outputs obtuse error messages. This commit
makes it so the test runner outputs the information that allows
programmers to figure out which JSON test has failed.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Apr 20 2018, 21:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2018, 21:17
teamcity added a subscriber: teamcity.Apr 20 2018, 21:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix requested changes to this revision.Apr 20 2018, 21:18
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/script_tests.cpp
1150 ↗(On Diff #3557)

So you catch a std::runtime_error in there.

1153 ↗(On Diff #3557)

So you can print e.what() as part of the error message.

This revision now requires changes to proceed.Apr 20 2018, 21:18
schancel updated this revision to Diff 3560.Apr 20 2018, 21:25

Address feedback from Malevolent Dictator.

deadalnix accepted this revision.Apr 20 2018, 21:26
deadalnix added inline comments.
src/test/script_tests.cpp
1150 ↗(On Diff #3560)

Maybe const ?

This revision is now accepted and ready to land.Apr 20 2018, 21:26
teamcity added a comment.Apr 20 2018, 21:36

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2356: Diff 3557.Apr 20 2018, 21:36
teamcity added a comment.Apr 20 2018, 22:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 20 2018, 22:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2359: Diff 3560!Apr 20 2018, 22:20
jasonbcox accepted this revision.Apr 21 2018, 23:21
jasonbcox added a subscriber: jasonbcox.

Check why build failed. The fail message says "success" so... v0v

teamcity added a comment.Apr 23 2018, 05:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 23 2018, 05:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2359: Diff 3560.Apr 23 2018, 05:32
Closed by commit rABC90ce4fff78f1: Make script_tests.cpp output verbose errors. (authored by schancel). · Explain WhyApr 24 2018, 04:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
22 lines

Diff 3581

View Options

src/test/script_tests.cpp

Loading...