Differential D13001

[avalanche] Make unit test cases const
ClosedPublic
Actions

Authored by sdulfari on Jan 18 2023, 21:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC04567cb58980: [avalanche] Make unit test cases const

Summary

Test cases are expected to be immutable.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Jan 18 2023, 21:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2023, 21:36

sdulfari requested review of this revision.Jan 18 2023, 21:36

Add some missing const

Harbormaster completed remote builds in B21784: Diff 37584.Jan 18 2023, 21:50

Harbormaster completed remote builds in B21785: Diff 37585.Jan 18 2023, 22:00

sdulfari added a child revision: D13002: [avalanche] Using C++17 structured bindings to make unit tests more readable.Jan 18 2023, 22:03

Fabien accepted this revision.Jan 19 2023, 09:31

This revision is now accepted and ready to land.Jan 19 2023, 09:31

Closed by commit rABC04567cb58980: [avalanche] Make unit test cases const (authored by sdulfari). · Explain WhyJan 19 2023, 17:03

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC04567cb58980: [avalanche] Make unit test cases const.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

8 lines

proof_tests.cpp

9 lines

Diff 37605

View Options

src/avalanche/test/processor_tests.cpp