[Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage
ClosedPublic
Actions

Authored by emack on Jan 23 2023, 12:30.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC51d97779c353: [Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage

Summary

T2551

Depends on D13019

This diff implements the logic in Alias.js which determines whether the alias cache object needs to be refreshed based on the last cached total tx count vs the onchain total tx count of the alias payment address.

At this point in the stack, this will always result in the need for a refresh since the updating of local forage will be implemented in the next diff.

[Cashtab] [Alias] pt 1 - Create scaffold for new Identity component
[Cashtab] [Alias] pt 2 - Upgrade sendXec() to handle alias registration
[Cashtab] [Alias] pt 3 - Implement isAliasAvailable function
[Cashtab] [Alias] pt 4 - Implement isAddressRegistered function
[Cashtab] [Alias] pt 5 - Implement getAddressFromAlias function
[Cashtab] [Alias] pt 6.1 - Get latest alias tx count from payment address
[Cashtab] [Alias] pt 6.1.1 - Apply Promise.All approach for alias history retrieval
[Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage
[Cashtab] [Alias] pt 6.3 - Implement updateAliases
[Cashtab] [Alias] pt 6.4 - Implement setAlisesToLocalForage
[Cashtab] [Alias] pt 6.5 - Deprecate caching related mocks and @TODOs
[Cashtab] [Alias] pt 7 - Enable alias lookup for Send XEC component
[Cashtab] [Alias] pt 8 - Enable alias lookup for Send Token component
[Cashtab] [Alias] pt 9 - Implement pricing mechanism
[Cashtab] [Alias] pt 10 - Server cron job
[Cashtab] [Alias] pt 11 - Upgrade tx history to recognize alias registration txs

Test Plan

npm test
npm start
navigate to the Alias page
note the passingloadstatus now that there are non-trivial logic being executed in useEffecT()
note the console log showing an alias refresh is required

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22025
Build 43685: Build Diff	cashtab-tests
Build 43684: arc lint + arc unit

Event Timeline

emack created this revision.Jan 23 2023, 12:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 12:30

emack requested review of this revision.Jan 23 2023, 12:30

Harbormaster completed remote builds in B21815: Diff 37634.Jan 23 2023, 12:33

What does this object look like in localForage?

Based on what we've learned so far, we should save both

All valid aliases
The tx count at the payment address up to which that list is valid

Probably something like

{
   aliasTxCount: 67,
   aliases: [ethan, joey, ..., chicken77]
}

This way the object could be taken as an input to getAllTxHistory, which would then know which page number to start from.

This revision now requires changes to proceed.Jan 23 2023, 18:14

In D13025#289452, @bytesofman wrote:
What does this object look like in localForage?

Based on what we've learned so far, we should save both

All valid aliases

The tx count at the payment address up to which that list is valid

Probably something like
{
   aliasTxCount: 67,
   aliases: [ethan, joey, ..., chicken77]
}
This way the object could be taken as an input to getAllTxHistory, which would then know which page number to start from.

it will look as follows:

{
     totalPaymentTxCount: 67,
     aliases: [
          {alias: 'ethan',  address: 'ecash....'},
          {alias: 'joey',  address: 'ecash....'},
          {alias: 'chicken77',  address: 'ecash....'},
     ]
}

emack added a child revision: D13049: [Cashtab] [Alias] pt 6.3 - Implement updateAliases.Jan 24 2023, 13:31

bytesofman accepted this revision.Jan 24 2023, 18:43

This revision is now accepted and ready to land.Jan 24 2023, 18:43

rebase

Harbormaster completed remote builds in B21929: Diff 37808.Feb 3 2023, 03:03

rebase

Harbormaster completed remote builds in B22025: Diff 37942.Feb 17 2023, 23:11

Closed by commit rABC51d97779c353: [Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage (authored by emack). · Explain WhyFeb 22 2023, 04:06

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC51d97779c353: [Cashtab] [Alias] pt 6.2 - Implement getAliasesFromLocalForage.