Page MenuHomePhabricator
Differential D13026

[Cashtab] Match transaction input sequence to node and ElectrumABC
ClosedPublic
Actions

Authored by bytesofman on Jan 23 2023, 18:28.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCbcc5efaff653: [Cashtab] Match transaction input sequence to node and ElectrumABC
Summary

T2925

Match Cashtab txs sequence number for inputs to eCash node and ElectrumABC.

Note: this will be implemented by default in the Bitgo utxo-lib transaction builder after that is implemented. For now, just overwrite the existing default in functions.

Test Plan

npm start
Send every kind of tx
Inspect for "sequence": 4294967294 in the JSON tab at https://explorer.bitcoinabc.org/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tx-sequencing-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21862
Build 43359: Build Diffcashtab-tests
Build 43358: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 23 2023, 18:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2023, 18:28
bytesofman requested review of this revision.Jan 23 2023, 18:28
bytesofman planned changes to this revision.Jan 23 2023, 18:28

Need to implement this in all the other tx building functions. May need to modify some unit test results.

Harbormaster completed remote builds in B21817: Diff 37641.Jan 23 2023, 18:30
bytesofman updated this revision to Diff 37711.Jan 24 2023, 19:44

implement in txbuilder, amend legacy unit tests

bytesofman updated this revision to Diff 37712.Jan 24 2023, 19:45

remove one-off implementation

bytesofman updated this revision to Diff 37713.Jan 24 2023, 19:46

Undo changes to transactions.js

Harbormaster completed remote builds in B21862: Diff 37711.Jan 24 2023, 19:47
Harbormaster completed remote builds in B21863: Diff 37712.
Harbormaster completed remote builds in B21864: Diff 37713.Jan 24 2023, 19:49
emack accepted this revision.Jan 24 2023, 23:55
This revision is now accepted and ready to land.Jan 24 2023, 23:55
Closed by commit rABCbcc5efaff653: [Cashtab] Match transaction input sequence to node and ElectrumABC (authored by bytesofman). · Explain WhyJan 25 2023, 16:51
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCbcc5efaff653: [Cashtab] Match transaction input sequence to node and ElectrumABC.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__tests__/
8 lines
2 lines
3 lines
2 lines

Diff 37711

View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/__tests__/txBuilder.test.js

Loading...
View Options

web/cashtab/src/utils/transactions.js

Loading...
View Options

web/cashtab/src/utils/txBuilder.js

Loading...