Require CBlockIndex::GetUndoPos() to hold mutex cs_main
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 07:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC99d5b835461c: Require CBlockIndex::GetUndoPos() to hold mutex cs_main

Summary

This is a partial backport of core#22932
https://github.com/bitcoin/bitcoin/pull/22932/commits/572393448b4d32f91b92edc84b4200ab52d62422

Depends on D13032

Test Plan

With clang and DEBUG:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2023, 07:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 07:13

PiRK requested review of this revision.Jan 24 2023, 07:13

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 07:13

PiRK added a child revision: D13034: Require CBlockIndex::RaiseValidity() to hold cs_main.Jan 24 2023, 07:14

Harbormaster completed remote builds in B21826: Diff 37651.Jan 24 2023, 07:35

Fabien accepted this revision.Jan 24 2023, 08:45

This revision is now accepted and ready to land.Jan 24 2023, 08:45

Closed by commit rABC99d5b835461c: Require CBlockIndex::GetUndoPos() to hold mutex cs_main (authored by PiRK). · Explain WhyJan 24 2023, 09:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC99d5b835461c: Require CBlockIndex::GetUndoPos() to hold mutex cs_main.

Revision Contents
Changeset List

Path

Size

src/

blockindex.h

3 lines

node/

blockstorage.cpp

3 lines

Diff 37662

View Options

src/blockindex.h