Page MenuHomePhabricator
Differential D13039

Fix BlockToJsonVerbose benchmark
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 09:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0724708e0da8: Fix BlockToJsonVerbose benchmark
Summary

Currently it was not possible to run just the BlockToJsonVerboes benchmarsk because it did not set up everything it needed, running bench_bitcoin -filter=BlockToJsonVerbose caused this assert to fail:

bench_bitcoin: chainparams.cpp:506: const CChainParams& Params(): Assertion `globalChainParams' failed.

Initializing TestingSetup fixes this.

This is a backport of core#20998

Test Plan
ninja bench-bitcoin
src/bench/bitcoin-bench -filter=BlockToJsonVerbose

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2023, 09:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 09:55
PiRK requested review of this revision.Jan 24 2023, 09:55
teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 09:55
PiRK added a child revision: D13040: Add benchmark to write JSON into a string.Jan 24 2023, 10:00
Harbormaster completed remote builds in B21834: Diff 37667.Jan 24 2023, 10:12
Fabien requested changes to this revision.Jan 24 2023, 10:18
Fabien added a subscriber: Fabien.

wrong pr

This revision now requires changes to proceed.Jan 24 2023, 10:18
PiRK requested review of this revision.Jan 24 2023, 10:20
PiRK edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jan 24 2023, 10:22
Fabien added inline comments.
src/bench/rpc_blockchain.cpp
10–14 ↗(On Diff #37667)
This revision is now accepted and ready to land.Jan 24 2023, 10:22
PiRK updated this revision to Diff 37670.Jan 24 2023, 10:27

include order

Harbormaster completed remote builds in B21836: Diff 37670.Jan 24 2023, 10:55
Closed by commit rABC0724708e0da8: Fix BlockToJsonVerbose benchmark (authored by Martin Ankerl <martin.ankerl@gmail.com>, committed by PiRK). · Explain WhyJan 24 2023, 11:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0724708e0da8: Fix BlockToJsonVerbose benchmark.

Revision Contents
Changeset List

PathSize
src/
bench/
4 lines

Diff 37674

View Options

src/bench/rpc_blockchain.cpp

Loading...