Page MenuHomePhabricator
Differential D13044

move-mostly: Make pindexBestHeader a ChainMan member
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 12:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe52a93e568aa: move-mostly: Make pindexBestHeader a ChainMan member
Summary

[META] In the next commit, we move the clearing of pindexBestHeader to ChainstateManager::Unload()

This is a partial backport of core#24909
https://github.com/bitcoin/bitcoin/pull/24909/commits/0d567daf23c9fcb2d95b38913ee45a8b0ba3b027

Depends on D13043

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 24 2023, 12:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 12:01
PiRK requested review of this revision.Jan 24 2023, 12:01
teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 12:01
PiRK added a child revision: D13045: Clear pindexBestHeader in ChainstateManager::Unload().Jan 24 2023, 12:03
Harbormaster completed remote builds in B21841: Diff 37677.Jan 24 2023, 12:16
Fabien accepted this revision.Jan 24 2023, 12:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
4988 ↗(On Diff #37677)

Shouldn't it be part of Unload ?

This revision is now accepted and ready to land.Jan 24 2023, 12:50
Closed by commit rABCe52a93e568aa: move-mostly: Make pindexBestHeader a ChainMan member (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 24 2023, 13:29
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe52a93e568aa: move-mostly: Make pindexBestHeader a ChainMan member.

Revision Contents
Changeset List

PathSize
src/
6 lines
47 lines
node/
3 lines
9 lines
7 lines
rpc/
5 lines
11 lines
30 lines

Diff 37688

View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/blockstorage.h

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/node/interfaces.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...