rpc: reduce LOCK(cs_main) scope in blockToJSON
ClosedPublic
Actions

Authored by PiRK on Jan 24 2023, 16:36.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCda006fdac29c: rpc: reduce LOCK(cs_main) scope in blockToJSON

Summary

This is a partial backport of core#26308
https://github.com/bitcoin/bitcoin/pull/26308/commits/efd82aec8a2dd0fca8f2597c3f84cefe057d1243

Depends on D13054

Test Plan

With Clang and DEBUG:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21856
Build 43347: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43346: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 24 2023, 16:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 16:36

PiRK requested review of this revision.Jan 24 2023, 16:36

teamcity edited the summary of this revision. (Show Details)Jan 24 2023, 16:36

PiRK added a child revision: D13056: rpc: reduce LOCK(cs_main) scope in GetUndoChecked and getblockstats.Jan 24 2023, 16:37

PiRK added a child revision: D13057: rpc: reduce LOCK(cs_main) scope in gettxoutproof.

Harbormaster completed remote builds in B21856: Diff 37701.Jan 24 2023, 17:04

sdulfari accepted this revision.Jan 24 2023, 18:20

This revision is now accepted and ready to land.Jan 24 2023, 18:20

Closed by commit rABCda006fdac29c: rpc: reduce LOCK(cs_main) scope in blockToJSON (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhyJan 25 2023, 07:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCda006fdac29c: rpc: reduce LOCK(cs_main) scope in blockToJSON.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

7 lines

Diff 37701

View Options

rpc: reduce LOCK(cs_main) scope in blockToJSONClosedPublicActions