Make PUSHDATA opcodes have names in ParseScript
ClosedPublic
Actions

Authored by schancel on Apr 25 2018, 01:50.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGb00eb5bde21c: Make PUSHDATA opcodes have names in ParseScript
rABCb00eb5bde21c: Make PUSHDATA opcodes have names in ParseScript

Summary

Currently, ParseScript does not recognize scripts which use the
full PUSHDATA opcode names. This commit enables the parser to
recognize these opcodes, and fixes script_tests.json to have
PUSHDATA opcodes be explicitly named.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2378
Build 2885: Bitcoin ABC Buildbot (legacy)
Build 2884: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 25 2018, 01:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2378: Diff 3587.Apr 25 2018, 02:12

deadalnix accepted this revision.Apr 25 2018, 23:16

This revision is now accepted and ready to land.Apr 25 2018, 23:16

Closed by commit rABCb00eb5bde21c: Make PUSHDATA opcodes have names in ParseScript (authored by schancel). · Explain WhyApr 26 2018, 14:26

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

core_read.cpp

3 lines

test/

data/

script_tests.json

44 lines

Diff 3587

View Options

src/core_read.cpp