Page MenuHomePhabricator
Differential D13079

[alias-server] [p6] outputScriptToAddress function and unit tests
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2023, 00:28.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC43800e59c2bc: [alias-server] [p6] outputScriptToAddress function and unit tests
Summary

T2922

Depends on D13078

Add a function to get P2SH or P2PKH ecash: address from an outputScript. Add unit tests.

The next diff in this stack will implement this function in getAliases and add unit tests there.

Test Plan

Review function and unit tests
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-node-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21898
Build 43431: Build Diff
Build 43430: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 31 2023, 00:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2023, 00:28
bytesofman requested review of this revision.Jan 31 2023, 00:28
Harbormaster completed remote builds in B21897: Diff 37765.Jan 31 2023, 00:28
bytesofman updated this revision to Diff 37766.Jan 31 2023, 00:38

Add unit test for outputScriptToAddress failure cases

Harbormaster completed remote builds in B21898: Diff 37766.Jan 31 2023, 00:38
bytesofman edited the summary of this revision. (Show Details)Jan 31 2023, 01:03
bytesofman added a parent revision: D13078: [alias-server] [p5] Commenced getAliases function.
bytesofman added a child revision: D13080: [alias-server] [p7] parseAliasTx and unit tests.Jan 31 2023, 01:05
emack accepted this revision.Feb 24 2023, 00:46
This revision is now accepted and ready to land.Feb 24 2023, 00:46
Closed by commit rABC43800e59c2bc: [alias-server] [p6] outputScriptToAddress function and unit tests (authored by bytesofman). · Explain WhyFeb 28 2023, 22:45
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC43800e59c2bc: [alias-server] [p6] outputScriptToAddress function and unit tests.

Revision Contents
Changeset List

PathSize
web/
alias-server/
2025 lines
9 lines
test/
32 lines
63 lines

Diff 37766

View Options

web/alias-server/package-lock.json

Loading...
View Options

web/alias-server/package.json

Loading...
View Options

web/alias-server/test/utils.js

Loading...
View Options

web/alias-server/utils.js

Loading...