Page MenuHomePhabricator

validation: No mempool clearing in UnloadBlockIndex
ClosedPublic

Authored by PiRK on Feb 1 2023, 14:12.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC9b392c5f8722: validation: No mempool clearing in UnloadBlockIndex
Summary

The only caller that uses this is ~ChainTestingSetup() where we
immediately destroy the mempool afterwards.

This is a partial backport of core#22564
https://github.com/bitcoin/bitcoin/pull/22564/commits/572d8319272ae84a81d6bfd53dd9685585697f65
https://github.com/bitcoin/bitcoin/pull/22564/commits/7d99d725cdb5428ed25dc07c2d7fddf420da7786

Note: the first commit is mostly not applicable to Bitcoin ABC, I mention it only because of the moving of ~ChainstateManager() from validation.h to validation.cpp. g_versionbitscache and warningcache are related to Core's BIP 9 and "buried deployments" business.

Depends on D13089

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Feb 1 2023, 14:12
sdulfari added a subscriber: sdulfari.

This patch looks ok as it is but the current state of the version bits business needs sorting out.

This revision is now accepted and ready to land.Feb 1 2023, 17:18