Paths

Table of Contentst

Differential D13090

validation: No mempool clearing in UnloadBlockIndex
ClosedPublic
Actions

Authored by PiRK on Feb 1 2023, 14:12.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9b392c5f8722: validation: No mempool clearing in UnloadBlockIndex

Summary

The only caller that uses this is ~ChainTestingSetup() where we
immediately destroy the mempool afterwards.

This is a partial backport of core#22564
https://github.com/bitcoin/bitcoin/pull/22564/commits/572d8319272ae84a81d6bfd53dd9685585697f65
https://github.com/bitcoin/bitcoin/pull/22564/commits/7d99d725cdb5428ed25dc07c2d7fddf420da7786

Note: the first commit is mostly not applicable to Bitcoin ABC, I mention it only because of the moving of ~ChainstateManager() from validation.h to validation.cpp. g_versionbitscache and warningcache are related to Core's BIP 9 and "buried deployments" business.

Depends on D13089

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 1 2023, 14:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2023, 14:12

PiRK requested review of this revision.Feb 1 2023, 14:12

teamcity edited the summary of this revision. (Show Details)Feb 1 2023, 14:12

Harbormaster completed remote builds in B21910: Diff 37782.Feb 1 2023, 14:40

PiRK added a child revision: D13091: make pindexBestForkTip and pindexBestForkBase private CChainState members.Feb 1 2023, 15:55

This patch looks ok as it is but the current state of the version bits business needs sorting out.

This revision is now accepted and ready to land.Feb 1 2023, 17:18

Closed by commit rABC9b392c5f8722: validation: No mempool clearing in UnloadBlockIndex (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyFeb 2 2023, 11:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9b392c5f8722: validation: No mempool clearing in UnloadBlockIndex.

Revision Contents
Changeset List

Path

Size

src/

test/

util/

setup_common.cpp

3 lines

7 lines

10 lines

Diff 37795

src/test/util/setup_common.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...