Differential D1310

[cmake] Check if boost::test require static or dynamic linking and act accordingly
ClosedPublic
Actions

Authored by deadalnix on Apr 26 2018, 17:20.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa9b3cb8ba319: [cmake] Check if boost::test require static or dynamic linking and act…
rABCa9b3cb8ba319: [cmake] Check if boost::test require static or dynamic linking and act…

Summary

Before, dynamic linking was just assumed, which is not always correct.

Test Plan

Do a cmake build with boost compiled as a static lib.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 26 2018, 17:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2018, 17:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2386: Diff 3598.Apr 26 2018, 17:53

schancel accepted this revision.Apr 26 2018, 23:50

This revision is now accepted and ready to land.Apr 26 2018, 23:50

Closed by commit rABCa9b3cb8ba319: [cmake] Check if boost::test require static or dynamic linking and act… (authored by deadalnix). · Explain WhyApr 27 2018, 16:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

13 lines

Diff 3611

src/test/CMakeLists.txt

Loading...