HomePhabricator
Diffusion Bitcoin ABC c3804927eb8a

Refactor sighash type test to go through every value possible in a…
c3804927eb8a
Actions

Description

Refactor sighash type test to go through every value possible in a transaction's signature.

Summary: This simplify the test case greatly. Also rename hasSupportedBaseType into isDefined and other small refactoring of the SigHashType class.

Test Plan:

make check

Reviewers: #bitcoin_abc, schancel

Reviewed By: #bitcoin_abc, schancel

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1313

Details

Provenance
deadalnixAuthored on Apr 26 2018, 17:37
deadalnixPushed on Apr 27 2018, 16:32
Reviewer
Restricted Project
Differential Revision
D1313: Refactor sighash type test to go through every value possible in a transaction's signature.
Parents
rABCfec9c2748973: Add test case that check midtstate caching for large transaction
Branches
Unknown
Tags
Unknown

Changes (3)

PathSize
src/
script/
test/

rABCc3804927eb8a

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/sighashtype.h

Loading...
View Options

src/test/script_sighashtype_tests.cpp

Loading...