Page MenuHomePhabricator

Refactor sighash type test to go through every value possible in a transaction's signature.
ClosedPublic

Authored by deadalnix on Apr 27 2018, 15:15.

Details

Summary

This simplify the test case greatly. Also rename hasSupportedBaseType into isDefined and other small refactoring of the SigHashType class.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
deadalnix created this revision.Apr 27 2018, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2018, 15:15
schancel accepted this revision.Apr 27 2018, 15:53
This revision is now accepted and ready to land.Apr 27 2018, 15:53
This revision was automatically updated to reflect the committed changes.