Paths

Table of Contentst

Differential D1313

Refactor sighash type test to go through every value possible in a transaction's signature.
ClosedPublic
Actions

Authored by deadalnix on Apr 27 2018, 15:15.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGc3804927eb8a: Refactor sighash type test to go through every value possible in a…
rABCc3804927eb8a: Refactor sighash type test to go through every value possible in a…

Summary

This simplify the test case greatly. Also rename hasSupportedBaseType into isDefined and other small refactoring of the SigHashType class.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sighashrefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2390
Build 2909: Bitcoin ABC Buildbot (legacy)
Build 2908: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 27 2018, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2018, 15:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2390: Diff 3604.Apr 27 2018, 15:34

schancel accepted this revision.Apr 27 2018, 15:53

This revision is now accepted and ready to land.Apr 27 2018, 15:53

Closed by commit rABCc3804927eb8a: Refactor sighash type test to go through every value possible in a… (authored by deadalnix). · Explain WhyApr 27 2018, 16:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

13 lines

sighashtype.h

7 lines

test/

script_sighashtype_tests.cpp

80 lines

Diff 3604

View Options

src/script/interpreter.cpp

View Options

src/script/sighashtype.h

View Options

src/test/script_sighashtype_tests.cpp

Refactor sighash type test to go through every value possible in a transaction's signature.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3604

src/script/interpreter.cpp

src/script/sighashtype.h

src/test/script_sighashtype_tests.cpp

Refactor sighash type test to go through every value possible in a transaction's signature.
ClosedPublic
Actions

Revision Contents
Changeset List