Page MenuHomePhabricator
Differential D13110

mempool: Add new index for sorting txs by fee
ClosedPublic
Actions

Authored by Fabien on Feb 7 2023, 17:16.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCb2540878a039: mempool: Add new index for sorting txs by fee
Summary
This adds a new mempool index that sorts transactions by modified fee
rate, ignoring ancestors.

Port of bchn#1079.

The comparator has been modified so that 2 different txs with the same
modified feerate and time will NOT be considered equal. This makes the
comparator usable for use in sets or maps.

Depends on D13109.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 7 2023, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2023, 17:16
Fabien requested review of this revision.Feb 7 2023, 17:16
teamcity edited the summary of this revision. (Show Details)Feb 7 2023, 17:16
Harbormaster completed remote builds in B21956: Diff 37844.Feb 7 2023, 17:37
Fabien planned changes to this revision.Feb 8 2023, 18:34
Fabien updated this revision to Diff 37858.Feb 8 2023, 20:20

Improve the test:

  • Remove the assert in favor of BOOST_CHECK
  • Simplify into a single lambda for testing ordering
Harbormaster completed remote builds in B21962: Diff 37858.Feb 8 2023, 20:47
sdulfari accepted this revision.Feb 9 2023, 00:13
This revision is now accepted and ready to land.Feb 9 2023, 00:13
Closed by commit rABCb2540878a039: mempool: Add new index for sorting txs by fee (authored by jtoomim, committed by Fabien). · Explain WhyFeb 9 2023, 08:45
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb2540878a039: mempool: Add new index for sorting txs by fee.

Revision Contents
Changeset List

PathSize
src/
test/
48 lines
34 lines
4 lines

Diff 37863

View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...