Page MenuHomePhabricator

[alias-server] [p9] Refactor functions to accept constants as input params
ClosedPublic

Authored by bytesofman on Feb 8 2023, 14:53.

Details

Summary

T2922

Depends on D13084

Since there are no secrets in config.js, start including it in the repo. Refactor functions in alias.js to accept alias constants as input params. This will allow unit tests to be created and preserved for test registration addresses and fee structures (and the production registration address and fee structure).

Test Plan

npm test and all pass

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-node-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21959
Build 43553: Build Diff
Build 43552: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Feb 24 2023, 04:06
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/test/alias.js
26

needs a test for alias with 8 char or more in length to pick up the fee mismatch from part 8

This revision now requires changes to proceed.Feb 24 2023, 04:06
bytesofman added inline comments.
web/alias-server/test/alias.js
26

Tracked with T2958

This revision is now accepted and ready to land.Feb 28 2023, 22:41