Page MenuHomePhabricator
Differential D13112

[alias-server] [p10] Store blockheight in parsed alias txs
ClosedPublic
Actions

Authored by bytesofman on Feb 8 2023, 15:13.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCd923885eec50: [alias-server] [p10] Store blockheight in parsed alias txs
Summary

T2922

Depends on D13111

Store blockheight in parsed alias txs. This is necessary to determine the valid alias in cases where the same alias has been registered multiple times.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-node-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21960
Build 43555: Build Diff
Build 43554: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 8 2023, 15:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2023, 15:13
bytesofman requested review of this revision.Feb 8 2023, 15:13
Harbormaster completed remote builds in B21960: Diff 37853.Feb 8 2023, 15:13
bytesofman added a child revision: D13115: [alias-server] [p11] Complete function set to achieve final alias registration result.Feb 8 2023, 23:41
emack requested changes to this revision.Feb 24 2023, 04:16
emack added a subscriber: emack.
emack added inline comments.
web/alias-server/alias.js
99

shouldn't the default blockheight be 100000000 if block.height did not exist (i.e. unconfirmed tx)?

This revision now requires changes to proceed.Feb 24 2023, 04:16
emack accepted this revision.Feb 24 2023, 04:49

Just saw this being rectified in part 11 so greening this

This revision is now accepted and ready to land.Feb 24 2023, 04:49
Closed by commit rABCd923885eec50: [alias-server] [p10] Store blockheight in parsed alias txs (authored by bytesofman). · Explain WhyFeb 28 2023, 22:46
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCd923885eec50: [alias-server] [p10] Store blockheight in parsed alias txs.

Revision Contents
Changeset List

PathSize
web/
alias-server/
2 lines
5 lines
2 lines
test/
42 lines
mocks/
309 lines

Diff 37853

View Options

web/alias-server/README.md

Loading...
View Options

web/alias-server/alias.js

Loading...
View Options

web/alias-server/index.js

Loading...
View Options

web/alias-server/test/alias.js

Loading...
View Options

web/alias-server/test/mocks/aliasMocks.js

Loading...