Paths

Table of Contentst

Differential D13130

[tests] use uint256_hex instead of repeating the string formatting pattern
ClosedPublic
Actions

Authored by PiRK on Feb 15 2023, 08:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC55ea1807d271: [tests] use uint256_hex instead of repeating the string formatting pattern

Summary

Follow-up to D11868

This change makes the code more readable by abstracting the int-to-hex string formatting.

Test Plan

ninja check-functional-extended

grep -r "064x" test/functional
grep -r "0{64}x" test/functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

uint256_hex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21989
Build 43613: Build Diff	build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 43612: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 15 2023, 08:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2023, 08:41

PiRK requested review of this revision.Feb 15 2023, 08:41

PiRK edited the test plan for this revision. (Show Details)Feb 15 2023, 08:43

nits: fix crazy autopep8 formatting, don't use a f-string to format the already formatted string returned by uint256_hex

Harbormaster completed remote builds in B21988: Diff 37894.Feb 15 2023, 09:13

Fabien accepted this revision.Feb 15 2023, 09:18

This revision is now accepted and ready to land.Feb 15 2023, 09:18

Harbormaster completed remote builds in B21989: Diff 37895.Feb 15 2023, 09:30

Closed by commit rABC55ea1807d271: [tests] use uint256_hex instead of repeating the string formatting pattern (authored by PiRK). · Explain WhyFeb 15 2023, 12:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC55ea1807d271: [tests] use uint256_hex instead of repeating the string formatting pattern.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_proof_inventory.py

7 lines

abc_rpc_avalancheproof.py

4 lines

abc_rpc_getavalancheinfo.py

4 lines

6 lines

4 lines

10 lines

6 lines

test_framework/

avatools.py

2 lines

messages.py

46 lines

test_framework.py

3 lines

Diff 37895

View Options

test/functional/abc_p2p_proof_inventory.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/test_framework/avatools.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/test_framework.py

[tests] use uint256_hex instead of repeating the string formatting patternClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37895

test/functional/abc_p2p_proof_inventory.py

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_getavalancheinfo.py

test/functional/p2p_compactblocks.py

test/functional/p2p_feefilter.py

test/functional/p2p_inv_download.py

test/functional/p2p_sendheaders.py

test/functional/test_framework/avatools.py

test/functional/test_framework/messages.py

test/functional/test_framework/test_framework.py

[tests] use uint256_hex instead of repeating the string formatting pattern
ClosedPublic
Actions

Revision Contents
Changeset List