Page MenuHomePhabricator

Dramatically reduce mempool_updatefromblock.py duration
ClosedPublic

Authored by Fabien on Feb 15 2023, 15:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2ee9e7767196: Dramatically reduce mempool_updatefromblock.py duration
Summary

The test intent is to check all the blocks txs are added back to the mempool in case of a reorg. It also checks for a weird edge case behavior that bypasses the number of descendants mempool limit during reorg.
But this test doesn't need to use so many transactions: we can take advantage of the -limitdescendantcount option to speed up the test, which is exactly what this diff does. Note that the ancestor limit is kept greater than the default so we keep checking that the option is properly enforced.

This takes down the time from 128s to 12s on my machine and moves the test out of the extended suite.

Depends on D13131.

Test Plan
./test/functional/test_runner.py mempool_updatefromblock

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dramatically_reduce_mempool_updatefromblock_duration
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21992
Build 43619: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 43618: arc lint + arc unit