Paths

Table of Contentst

Differential D13158

remove most of versionbits / BIP9 related code
ClosedPublic
Actions

Authored by PiRK on Feb 22 2023, 14:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6ddc21d7b485: remove most of versionbits / BIP9 related code

Summary

The only remaining piece is ComputeBlockVersion and code related to BuriedDeployments

The functional test mining_basic.py needs a change because the removed TESTDUMMY deployment was always active on testnet, and this is the only place where it was tested. There is no need to keep this test.

Depends on D13157

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 22 2023, 14:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2023, 14:20

PiRK requested review of this revision.Feb 22 2023, 14:20

Harbormaster completed remote builds in B22056: Diff 37997.Feb 22 2023, 14:48

Fabien accepted this revision.Feb 23 2023, 10:56

This revision is now accepted and ready to land.Feb 23 2023, 10:56

rebase

Harbormaster completed remote builds in B22076: Diff 38026.Feb 24 2023, 11:19

Closed by commit rABC6ddc21d7b485: remove most of versionbits / BIP9 related code (authored by PiRK). · Explain WhyFeb 24 2023, 16:54

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in rABC71ba268ed11b: deprecate softforks from getblockchaininfo RPC.

PiRK added a commit: rABC6ddc21d7b485: remove most of versionbits / BIP9 related code.

Revision Contents
Changeset List

Path

Size

src/

chainparams.cpp

32 lines

consensus/

params.h

49 lines

deploymentstatus.h

4 lines

deploymentstatus.cpp

23 lines

node/

miner.cpp

5 lines

test/

CMakeLists.txt

1 line

versionbits_tests.cpp

versionbits.h

72 lines

versionbits.cpp

159 lines

test/

functional/

mining_basic.py

3 lines

Diff 38031

View Options

src/chainparams.cpp

View Options

src/consensus/params.h

View Options

src/deploymentstatus.h

View Options

src/deploymentstatus.cpp

View Options

src/node/miner.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/versionbits_tests.cpp

View Options

src/versionbits.h

View Options

src/versionbits.cpp

View Options

test/functional/mining_basic.py

remove most of versionbits / BIP9 related codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38031

src/chainparams.cpp

src/consensus/params.h

src/deploymentstatus.h

src/deploymentstatus.cpp

src/node/miner.cpp

src/test/CMakeLists.txt

src/test/versionbits_tests.cpp

src/versionbits.h

src/versionbits.cpp

test/functional/mining_basic.py

remove most of versionbits / BIP9 related code
ClosedPublic
Actions

Revision Contents
Changeset List