Page MenuHomePhabricator
Differential D13165

[alias-server] [p17] Add API endpoint, MVP of app
ClosedPublic
Actions

Authored by bytesofman on Feb 23 2023, 19:06.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC030cb6819c04: [alias-server] [p17] Add API endpoint, MVP of app
Summary

T2922

Depends on D13162

Add an API endpoint that delivers a JSON of valid alias-address pairs

Test Plan

node index.js
Navigate to localhost:5000/aliases in browser
Should see aliases

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-node-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22069
Build 43773: Build Diff
Build 43772: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 23 2023, 19:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 23 2023, 19:06
bytesofman requested review of this revision.Feb 23 2023, 19:06
Harbormaster completed remote builds in B22069: Diff 38017.Feb 23 2023, 19:06
emack requested changes to this revision.Feb 24 2023, 20:37
emack added a subscriber: emack.

image.png (528×1 px, 135 KB)

After starting mongodb, then running index.js, Mongo starts complaining about duplicate keys in the DB

This revision now requires changes to proceed.Feb 24 2023, 20:37
bytesofman requested review of this revision.Feb 24 2023, 22:37

Can you try re-running after changing the name of the db in config.js or deleting the database in mongodb?

This is probably from testing earlier diffs when the logic to prevent this wasn't in yet.

emack accepted this revision.Feb 25 2023, 12:03

LGTM

image.png (197×705 px, 52 KB)

This revision is now accepted and ready to land.Feb 25 2023, 12:03
Closed by commit rABC030cb6819c04: [alias-server] [p17] Add API endpoint, MVP of app (authored by bytesofman). · Explain WhyFeb 28 2023, 22:46
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC030cb6819c04: [alias-server] [p17] Add API endpoint, MVP of app.

Revision Contents
Changeset List

PathSize
web/
alias-server/
117 lines
1 line
22 lines
964 lines
1 line

Diff 38017

View Options

web/alias-server/README.md

Loading...
View Options

web/alias-server/config.js

Loading...
View Options

web/alias-server/index.js

Loading...
View Options

web/alias-server/package-lock.json

Loading...
View Options

web/alias-server/package.json

Loading...