Differential D13175

Fix the deprecation warnings from new boost versions
ClosedPublic
Actions

Authored by Fabien on Feb 27 2023, 14:07.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0804f1a95b7a: Fix the deprecation warnings from new boost versions

Summary

A better solution would be to remove boost fs and boost system depedencies, but since it's a huge work (see https://github.com/bitcoin/bitcoin/pull/20744) let's fix the annoying warnings for now.

Test Plan

ninja all check

Make sure there is no warning anymore

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 27 2023, 14:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2023, 14:07

Fabien requested review of this revision.Feb 27 2023, 14:07

Harbormaster completed remote builds in B22101: Diff 38058.Feb 27 2023, 14:24

Note that most of the fs::filesystem work is done in https://reviews.bitcoinabc.org/D11974 (it needs to be rebased, but I don't expect too many conflicts). Sadly the compiler for the win64 CI build will still not work.

PiRK accepted this revision.Feb 27 2023, 14:26

This revision is now accepted and ready to land.Feb 27 2023, 14:26

Closed by commit rABC0804f1a95b7a: Fix the deprecation warnings from new boost versions (authored by Fabien). · Explain WhyFeb 27 2023, 15:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0804f1a95b7a: Fix the deprecation warnings from new boost versions.

Fabien added a reverting change: D13181: Revert "Fix the deprecation warnings from new boost versions".Feb 27 2023, 15:48

Fabien added a reverting change: rABC6ad28d0483ae: Revert "Fix the deprecation warnings from new boost versions".Feb 27 2023, 16:03