test: check for RPC error 'Transaction already in block chain' (-27)
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 10:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc77dbd76afc5: test: check for RPC error 'Transaction already in block chain' (-27)

Summary

This is a backport of core#22510

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 28 2023, 10:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 10:14

PiRK requested review of this revision.Feb 28 2023, 10:14

teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 10:14

Fabien requested changes to this revision.Feb 28 2023, 10:17

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/rpc_rawtransaction.py
695–696 ↗	(On Diff #38094)	You either don't need the sync, or better move it to the generate

This revision now requires changes to proceed.Feb 28 2023, 10:17

Harbormaster completed remote builds in B22125: Diff 38094.Feb 28 2023, 10:28

remove unnecessary sync_blocks (generate alreadey does sync_all)

Harbormaster completed remote builds in B22128: Diff 38098.Feb 28 2023, 12:57

Fabien accepted this revision.Feb 28 2023, 12:58

This revision is now accepted and ready to land.Feb 28 2023, 12:58

Closed by commit rABCc77dbd76afc5: test: check for RPC error 'Transaction already in block chain' (-27) (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyFeb 28 2023, 13:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc77dbd76afc5: test: check for RPC error 'Transaction already in block chain' (-27).

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_rawtransaction.py

11 lines

Diff 38101

View Options

test/functional/rpc_rawtransaction.py

test: check for RPC error 'Transaction already in block chain' (-27)ClosedPublicActions