validation, test, bench: make CScriptCheck and prevector swap member functions noexcept
ClosedPublic
Actions

Authored by PiRK on Feb 28 2023, 13:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdfa3cc728d5e: validation, test, bench: make CScriptCheck and prevector swap member functions…

Summary

Reason:
A swap must not fail; when a class has a swap member function, it should be declared noexcept.
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c84-a-swap-function-must-not-fail

This is a backport of core#25017

Test Plan

ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr25017

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22129
Build 43893: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang · build-clang-tidy · build-bench
Build 43892: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 28 2023, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2023, 13:09

PiRK requested review of this revision.Feb 28 2023, 13:09

teamcity edited the summary of this revision. (Show Details)Feb 28 2023, 13:09

Harbormaster completed remote builds in B22129: Diff 38100.Feb 28 2023, 13:28

Fabien accepted this revision.Feb 28 2023, 13:28

Fabien retitled this revision from validation, test, becnh: make CScriptCheck and prevector swap member functions noexcept to validation, test, bench: make CScriptCheck and prevector swap member functions noexcept.

This revision is now accepted and ready to land.Feb 28 2023, 13:29

Closed by commit rABCdfa3cc728d5e: validation, test, bench: make CScriptCheck and prevector swap member functions… (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 28 2023, 16:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdfa3cc728d5e: validation, test, bench: make CScriptCheck and prevector swap member functions….