Page MenuHomePhabricator
Differential D13212

[tests] use f-string instead of .format(*tuple)
ClosedPublic
Actions

Authored by PiRK on Mar 1 2023, 14:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC28299c3c4142: [tests] use f-string instead of .format(*tuple)
Summary

This is more readable than unpacking tuples.

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK created this revision.Mar 1 2023, 14:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2023, 14:08
PiRK requested review of this revision.Mar 1 2023, 14:08
Harbormaster completed remote builds in B22178: Diff 38190.Mar 1 2023, 14:41
Fabien requested changes to this revision.Mar 1 2023, 15:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/interface_rest.py
110

it's no longer used and can be removed

This revision now requires changes to proceed.Mar 1 2023, 15:24
PiRK added a child revision: D13215: use f-strings in test_framework (long lines).Mar 1 2023, 15:34
PiRK requested review of this revision.Mar 1 2023, 17:05
PiRK added inline comments.
test/functional/interface_rest.py
153

It is still used here.

Fabien accepted this revision.Mar 1 2023, 18:13
Fabien added inline comments.
test/functional/interface_rest.py
153

I didn't expand the diff enough for my ctrl+f to pick it...

This revision is now accepted and ready to land.Mar 1 2023, 18:13
Closed by commit rABC28299c3c4142: [tests] use f-string instead of .format(*tuple) (authored by PiRK). · Explain WhyMar 1 2023, 18:17
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC28299c3c4142: [tests] use f-string instead of .format(*tuple).

Revision Contents
Changeset List

PathSize
test/
functional/
27 lines
31 lines

Diff 38190

View Options

test/functional/feature_proxy.py

Loading...
View Options

test/functional/interface_rest.py

Loading...