Page MenuHomePhabricator
Differential D13213

[Chronik] Build proto for python + HTTP 404 proto fallback
ClosedPublic
Actions

Authored by tobias_ruck on Mar 1 2023, 14:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc206fe38d6ff: [Chronik] Build proto for python + HTTP 404 proto fallback
Summary
  1. Compile protobuf for python using protobuf_generate_python in CMake.
  2. Add generated python modules to sys.path.
  3. Add a 404 fallback for the HTTP server.
Test Plan
  1. ninja check-functional to generate python protobuf
  2. Ctrl+C once tests start
  3. ./test/functional/test_runner.py chronik_serve

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Mar 1 2023, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2023, 14:42
Harbormaster completed remote builds in B22179: Diff 38191.Mar 1 2023, 14:42
tobias_ruck updated this revision to Diff 38194.Mar 1 2023, 16:42

fix sys.path for python; add 404 http protobuf fallback

tobias_ruck updated this revision to Diff 38197.Mar 1 2023, 16:55

Test Content-Type == application/x-protobuf, add protobuf to requirements.txt

tobias_ruck retitled this revision from [Chronik] Build proto for python to [Chronik] Build proto for python + HTTP 404 proto fallback.Mar 1 2023, 16:56
tobias_ruck edited the summary of this revision. (Show Details)
tobias_ruck edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B22182: Diff 38194.Mar 1 2023, 16:56
teamcity added a comment.Mar 1 2023, 16:56
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck published this revision for review.Mar 1 2023, 17:02

seems like the CI broke

Unknown Object (User) added a subscriber: Unknown Object (User).Mar 1 2023, 17:08
Harbormaster completed remote builds in B22185: Diff 38197.Mar 1 2023, 17:25
teamcity added a comment.Mar 1 2023, 17:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 38202.Mar 1 2023, 18:11
tobias_ruck edited the summary of this revision. (Show Details)
tobias_ruck edited the test plan for this revision. (Show Details)

Add to install-dependencies-bullseye.sh

Harbormaster completed remote builds in B22188: Diff 38202.Mar 1 2023, 18:35
teamcity added a comment.Mar 1 2023, 18:35
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 38206.Mar 1 2023, 19:06

install older protobuf version

Fabien added inline comments.Mar 1 2023, 19:15
contrib/buildbot/requirements.txt
9 ↗(On Diff #38206)

remove

tobias_ruck updated this revision to Diff 38207.Mar 1 2023, 19:23

remove protobuf

Harbormaster completed remote builds in B22189: Diff 38206.Mar 1 2023, 19:32
teamcity added a comment.Mar 1 2023, 19:32
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Harbormaster completed remote builds in B22190: Diff 38207.Mar 1 2023, 19:46
teamcity added a comment.Mar 1 2023, 19:46
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 38208.Mar 1 2023, 20:05

use protobuf<=3.20

Fabien requested changes to this revision.Mar 1 2023, 20:25
Fabien added inline comments.
test/CMakeLists.txt
62 ↗(On Diff #38208)

Beware paths can contain spaces, so enclose with quotes

test/functional/chronik_serve.py
23 ↗(On Diff #38208)

Move to top

This revision now requires changes to proceed.Mar 1 2023, 20:25
Harbormaster completed remote builds in B22191: Diff 38208.Mar 1 2023, 20:34
tobias_ruck updated this revision to Diff 38210.Mar 1 2023, 20:45
tobias_ruck marked 2 inline comments as done.

add quotes + custom all target for python proto files

Fabien accepted this revision.Mar 1 2023, 20:47
This revision is now accepted and ready to land.Mar 1 2023, 20:47
Harbormaster completed remote builds in B22193: Diff 38210.Mar 1 2023, 21:12
Closed by commit rABCc206fe38d6ff: [Chronik] Build proto for python + HTTP 404 proto fallback (authored by tobias_ruck). · Explain WhyMar 1 2023, 21:15
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCc206fe38d6ff: [Chronik] Build proto for python + HTTP 404 proto fallback.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
22 lines
1 line
10 lines
contrib/
utils/
3 lines
test/
6 lines
functional/
7 lines
test_framework/
3 lines

Diff 38213

View Options

chronik/chronik-http/src/handlers.rs

Loading...
View Options

chronik/chronik-http/src/lib.rs

Loading...
View Options

chronik/chronik-http/src/server.rs

Loading...
View Options

contrib/utils/install-dependencies-bullseye.sh

Loading...
View Options

test/CMakeLists.txt

Loading...
View Options

test/functional/chronik_serve.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...