Page MenuHomePhabricator

[Chronik] Build proto for python + HTTP 404 proto fallback
ClosedPublic

Authored by tobias_ruck on Mar 1 2023, 14:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc206fe38d6ff: [Chronik] Build proto for python + HTTP 404 proto fallback
Summary
  1. Compile protobuf for python using protobuf_generate_python in CMake.
  2. Add generated python modules to sys.path.
  3. Add a 404 fallback for the HTTP server.
Test Plan
  1. ninja check-functional to generate python protobuf
  2. Ctrl+C once tests start
  3. ./test/functional/test_runner.py chronik_serve

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-build-python-proto
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22190
Build 44015: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-chronik
Build 44014: arc lint + arc unit

Event Timeline

fix sys.path for python; add 404 http protobuf fallback

Test Content-Type == application/x-protobuf, add protobuf to requirements.txt

tobias_ruck retitled this revision from [Chronik] Build proto for python to [Chronik] Build proto for python + HTTP 404 proto fallback.Mar 1 2023, 16:56
tobias_ruck edited the summary of this revision. (Show Details)
tobias_ruck edited the test plan for this revision. (Show Details)
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

seems like the CI broke

Unknown Object (User) added a subscriber: Unknown Object (User).Mar 1 2023, 17:08
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck edited the summary of this revision. (Show Details)
tobias_ruck edited the test plan for this revision. (Show Details)

Add to install-dependencies-bullseye.sh

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

install older protobuf version

contrib/buildbot/requirements.txt
9 ↗(On Diff #38206)

remove

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien requested changes to this revision.Mar 1 2023, 20:25
Fabien added inline comments.
test/CMakeLists.txt
62 ↗(On Diff #38208)

Beware paths can contain spaces, so enclose with quotes

test/functional/chronik_serve.py
23 ↗(On Diff #38208)

Move to top

This revision now requires changes to proceed.Mar 1 2023, 20:25
tobias_ruck marked 2 inline comments as done.

add quotes + custom all target for python proto files

This revision is now accepted and ready to land.Mar 1 2023, 20:47