Paths

Table of Contentst

Differential D13217

[Chronik] Fix build for Windows, fix `util/hash.h`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 1 2023, 17:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbf056d07c3fa: [Chronik] Fix build for Windows, fix `util/hash.h`

Summary

The windows build fails because uint8_t is not defined, so we add #include <cstdint>.

Test Plan

ninja
Run the CI windows build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-fix-util-hash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22186
Build 44007: Build Diff	build-chronik
Build 44006: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 1 2023, 17:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2023, 17:02

@bot build-win64

teamcity awarded a token.Mar 1 2023, 17:18

Harbormaster completed remote builds in B22186: Diff 38199.Mar 1 2023, 17:30

Unknown Object (User) added a subscriber: Unknown Object (User).Mar 1 2023, 17:44

tobias_ruck published this revision for review.Mar 1 2023, 18:07

Fabien edited the summary of this revision. (Show Details)Mar 1 2023, 18:10

Fabien edited the test plan for this revision. (Show Details)

Fabien accepted this revision.Mar 1 2023, 18:54

This revision is now accepted and ready to land.Mar 1 2023, 18:54

Closed by commit rABCbf056d07c3fa: [Chronik] Fix build for Windows, fix `util/hash.h` (authored by tobias_ruck). · Explain WhyMar 1 2023, 21:17

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCbf056d07c3fa: [Chronik] Fix build for Windows, fix `util/hash.h`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

util/

hash.h

1 line

Diff 38199

View Options

chronik/chronik-cpp/util/hash.h

[Chronik] Fix build for Windows, fix `util/hash.h`ClosedPublicActions